Changeset 497 in openpam

Timestamp:

11/21/11 16:25:49 (18 months ago)

Author:

des

Message:

Validate the service name, closing an attack vector for programs like
kcheckpass that let the user specify which policy to apply. See
<URL:http://c-skills.blogspot.com/2011/11/openpam-trickery.html>.

File:

• trunk/lib/openpam_configure.c (modified) (1 diff)

trunk/lib/openpam_configure.c

@@ -557 +557 @@
 {
         pam_facility_t fclt;
+        const char *p;
+
+        for (p = service; *p; ++p)
+                if (!is_pfcs(*p))
+                        return (PAM_SYSTEM_ERR);
 
         if (openpam_load_chain(pamh, service, PAM_FACILITY_ANY) != PAM_SUCCESS)