Changeset 101 in openpam for trunk/lib/pam_get_authtok.c

Timestamp:

Apr 6, 2002, 5:17:44 PM (19 years ago)

Author:

Dag-Erling Smørgrav

Message:

Plug memory leak, reduce differences between these very similar
functions, and {add,tweak} documentation.

Sponsored by: DARPA, NAI Labs

File:

• trunk/lib/pam_get_authtok.c (modified) (3 diffs)

trunk/lib/pam_get_authtok.c

@@ -32 +32 @@
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/openpam/lib/pam_get_authtok.c#13 $
+ * $P4: //depot/projects/openpam/lib/pam_get_authtok.c#14 $
  */
 
 #include <sys/param.h>
+
+#include <stdlib.h>
 
 #include <security/pam_appl.h>
@@ -96 +98 @@
         if (r != PAM_SUCCESS)
                 return (r);
-        *authtok = resp;
-        return (pam_set_item(pamh, item, *authtok));
+        r = pam_set_item(pamh, pitem, resp);
+        free(resp);
+        if (r != PAM_SUCCESS)
+                return (r);
+        return (pam_get_item(pamh, pitem, (const void **)authtok));
 }
 
@@ -125 +130 @@
  *
  * The =prompt argument specifies a prompt to use if no token is cached.
- * If =NULL, the =PAM_AUTHTOK_PROMPT or =PAM_OLDAUTHTOK_PROMPT item, as
- * appropriate, will be used.  If that item is also =NULL, a hardcoded
+ * If it is =NULL, the =PAM_AUTHTOK_PROMPT or =PAM_OLDAUTHTOK_PROMPT item,
+ * as appropriate, will be used.  If that item is also =NULL, a hardcoded
  * default prompt will be used.
  *
  * >pam_get_item
+ * >pam_get_user
  */