Changeset 525 in openpam

Timestamp:

Jan 11, 2012, 12:45:09 AM (9 years ago)

Author:

Dag-Erling Smørgrav

Message:

Improve error messages by logging the full path of the module we tried
to load rather than just the module name.

File:

• trunk/lib/openpam_dynamic.c (modified) (3 diffs)

trunk/lib/openpam_dynamic.c

@@ -100 +100 @@
 }
 #endif
-    
+
 /*
  * OpenPAM internal
@@ -132 +132 @@
                 dlh = try_dlopen(vpath);
         }
-        serrno = errno;
-        FREE(vpath);
-        errno = serrno;
         if (dlh == NULL)
                 goto err;
@@ -165 +162 @@
                 }
         }
+        FREE(vpath);
         return (module);
 buf_err:
+        serrno = errno;
         if (dlh != NULL)
                 dlclose(dlh);
         FREE(module);
+        errno = serrno;
 err:
+        serrno = errno;
         if (errno != 0)
-                openpam_log(PAM_LOG_ERROR, "%s: %m", path);
+                openpam_log(PAM_LOG_ERROR, "%s: %m", vpath);
+        FREE(vpath);
+        errno = serrno;
         return (NULL);
 }