Changeset 684 in openpam for trunk

Timestamp:

Apr 14, 2013, 3:44:32 PM (8 years ago)

Author:

Dag-Erling Smørgrav

Message:

OPENPAM_DEBUG (--enable-debug) has a double action: it enables the
debugging macros, and sets the initial value of openpam_debug to 1.
This effectively gives the user a choice between no debugging at all,
or drowning in debugging messages from every part of the system.

Assuming that the primary use case for debugging is to allow admins to
troubleshoot their policies by adding the debug option to selected
pam.conf entries, remove the initialization of openpam_debug to 1.
This allows integrators to ship OpenPAM with OPENPAM_DEBUG defined
without spamming /var/log.

Location:

trunk

Files:

• autogen.des (modified) (1 diff)
• configure.ac (modified) (1 diff)
• lib/libpam/openpam_log.c (modified) (1 diff)

trunk/autogen.des

@@ -18 +18 @@
         --with-su \
         --with-modules-dir=/usr/lib \
+        --enable-debug \
         --enable-developer-warnings \
         --enable-werror \

trunk/configure.ac

@@ -32 +32 @@
 AC_ARG_ENABLE([debug],
     AC_HELP_STRING([--enable-debug],
-        [turn debugging on by default]),
-    AC_DEFINE(OPENPAM_DEBUG, 1, [Turn debugging on by default]))
+        [turn debugging macros on]),
+    AC_DEFINE(OPENPAM_DEBUG, 1, [Turn debugging macros on]))
 
 AC_ARG_ENABLE([unversioned-modules],

trunk/lib/libpam/openpam_log.c

@@ -51 +51 @@
 #include "openpam_asprintf.h"
 
-#ifdef OPENPAM_DEBUG
-int openpam_debug = 1;
-#else
 int openpam_debug = 0;
-#endif
 
 #if !defined(openpam_log)