Changeset 745 in openpam

Timestamp:

Sep 21, 2013, 11:22:48 PM (7 years ago)

Author:

Dag-Erling Smørgrav

Message:

Currently, openpam_policy_path is a hardcoded array of short strings, and
filename is much larger than it needs to be. However, this might not be
the case in the future. To be safe, add a length check after strlcpy().
This should silence a Coverity warning about possible array overflow.

File:

• trunk/lib/libpam/openpam_configure.c (modified) (1 diff)

trunk/lib/libpam/openpam_configure.c

@@ -391 +391 @@
                 /* construct filename */
                 len = strlcpy(filename, *path, sizeof filename);
+                if (len >= sizeof filename) {
+                        errno = ENAMETOOLONG;
+                        RETURNN(-1);
+                }
                 if (filename[len - 1] == '/') {
                         len = strlcat(filename, service, sizeof filename);