Changeset 756 in openpam

Timestamp:

Jan 22, 2014, 3:13:56 PM (7 years ago)

Author:

Dag-Erling Smørgrav

Message:

Do not use oath_[ht]otp_match() as predicates - a non-zero return can
mean an error occurred. We should probably switch to the standard
Unix idiom of returning 0 for success.

File:

• trunk/modules/pam_oath/pam_oath.c (modified) (1 diff)

trunk/modules/pam_oath/pam_oath.c

@@ -272 +272 @@
         }
         openpam_log(PAM_LOG_VERBOSE, "verification code %s",
-            ret ? "matched" : "did not match");
-        if (ret == 0) {
-                pam_err = PAM_AUTH_ERR;
+            ret > 0 ? "matched" : "did not match");
+        if (ret <= 0) {
+                pam_err = ret < 0 ? PAM_SERVICE_ERR : PAM_AUTH_ERR;
                 goto done;
         }